Review Request 114084: Fix warning on __new__ method argument complain

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114084/#review44320
-----------------------------------------------------------


Seems ok functionality-wise, but please see below how to improve the code. ;)
Also can you please write a unit test for this? Just create a new test function which verifies that the list of problems is empty / not empty for the two relevant cases.


duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/114084/#comment31707>

    All this code is now duplicated, while really you only need to change the description of the error. Save the description in a QString first, and only then create the problem.



duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/114084/#comment31708>

    While you're at it, make those IndexedStrings static.


- Sven Brauch


On Nov. 24, 2013, 3:31 p.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114084/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2013, 3:31 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> This patch fixes a warning on __new__ method argument complaining about the usage of self instead of cls.
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.cpp c711fd7 
> 
> Diff: http://git.reviewboard.kde.org/r/114084/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131124/c88d82df/attachment.html>