Review Request 113954: Remove dead code related to kompare support
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Nov 19 23:40:57 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113954/#review43994
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 19, 2013, 10:54 p.m., Kevin Funk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113954/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 10:54 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> Remove dead code related to kompare support
>
> Never used.
>
> Minor: Code cleanup
>
>
> ApplyChangesWidget: Get rid off kompare support
>
> Never used, and never enabled since 2009.
>
> ApplyChangesWidget: Remove useless changes view
>
> Just clutters the view, doesn't really provide information
>
> Minor: Cleanup code
>
>
> Diffs
> -----
>
> CMakeLists.txt ee6ee330078ceae283823c112f50afb6b295cc25
> config-kdevplatform.h.cmake ff1db70ab10ff558f0881a31ff63b26d02f5d859
> language/CMakeLists.txt 2f777e4ffab3f8b7dca814d09d9a9492861814e6
> language/codegen/applychangeswidget.h d316d826d14b6118b4c40996ef0726cf788bb867
> language/codegen/applychangeswidget.cpp c5c0a5c3ea4eee72b888b47d9eab84d04cb9341c
> language/codegen/komparesupport.h 001144ad162a3913430bc46c6d90337fc14a3327
> language/codegen/komparesupport.cpp c5c04ed092e8723613a5e97ca5777cd0f2ac479f
> shell/CMakeLists.txt 57c5b72c3eef30e37c3a9c58016c6eb247f53e23
> shell/documentcontroller.cpp 21916b359bc88ed87d2353ffccb408cf243dcf89
> shell/patchdocument.h fe0d7de2d0a32c211a567a4d312de461a59d0c98
> shell/patchdocument.cpp 724ce2af92882cbe336bd389e2e99b38a0c820e9
> vcs/vcspluginhelper.cpp 0456aee4c1395a90d3c51009cfc1cd662afbf2c3
>
> Diff: http://git.reviewboard.kde.org/r/113954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Funk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131119/8e946070/attachment.html>
More information about the KDevelop-devel
mailing list