Review Request 113932: Save correct combo box value in grepview plugin

Kevin Funk krf at gmx.de
Tue Nov 19 09:25:28 UTC 2013



> On Nov. 19, 2013, 9:25 a.m., Kevin Funk wrote:
> > Ship It!

Can you commit? Do you have push rights?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113932/#review43924
-----------------------------------------------------------


On Nov. 19, 2013, 5:47 a.m., Steffen Ohrendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113932/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 5:47 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The grepview plugin saved the search template as the replacement template; e.g., when searching for "\b%s\b" and replacing with "%s", the next time the replacement template would also be "\b%s\b". This patch fixes that by retrieving the template from the right combo box.
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepdialog.cpp 0c850ab 
> 
> Diff: http://git.reviewboard.kde.org/r/113932/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Steffen Ohrendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131119/07638d7d/attachment.html>


More information about the KDevelop-devel mailing list