Review Request 113584: Ask git if it is safe to reload a document

Sven Brauch svenbrauch at
Mon Nov 11 18:42:20 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 11, 2013, 6:42 p.m.)


This change has been marked as submitted.

Review request for KDevelop, Aleix Pol Gonzalez and Milian Wolff.

Repository: kdevplatform


When a file is changed on disk, we can look in the git object repository
and see whether the contents currently in the editor are stored somewhere
there. In that case, there is no risk of data loss when we just silently
reload the document; the user can always retrieve the old version from

For this purpose I added a new VCS interface which version control plugins
can choose to implement if they are able and willing to provide this
functionality. If a plugin does not implement the interface, the old
behaviour is unaffected.

I implemented the interface for the git plugin and it seems to be working fine.
There's two issues we might want to talk about:
 - We can not retrieve the line ending mode from kate. Thus, currently it will
   only work for files with \n line endings (old behaviour is used instead for
   different line endings).
 - It's not blazingly fast. It's not exactly slow, but if you have like 35
   documents open, the freeze on switching to a completely different branch
   is noticeable. Test it yourself and give your opinion on whether this
   is acceptable or not.


  shell/textdocument.cpp 187a071d78c3e2d00092bb2adde533486be11eee 
  shell/textdocument.h 8bb29fea8395d4cac956778fae85a4a9f57c2cce 
  plugins/git/gitplugin.cpp 27f4eaeea46afdfccb88d64caf161cc84a1e5bad 
  plugins/git/gitplugin.h 2f60c24b9d223a815eda6627d1328ce2404e11af 
  vcs/interfaces/icontentawareversioncontrol.cpp PRE-CREATION 
  vcs/interfaces/icontentawareversioncontrol.h PRE-CREATION 
  vcs/CMakeLists.txt c6854ed895e4284e4b3d355b0b549ef74a8f84de 




Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list