Review Request 113584: Ask git if it is safe to reload a document

[Andreas Pakulat]

> On Nov. 2, 2013, 7:46 p.m., Andreas Pakulat wrote:
> > Something I'm missing: What problem does this solve?
> > 
> > And 35 documents is not exactly that much, at least when I still used KDevelop I easily had 30 docs open at the same time.
> 
> Sven Brauch wrote:
>     Yes we should talk about performance, I think we can make it much faster.
>     
>     The problem it solves is that currently, if you open ten documents (without modifying them!) and then switch to a different branch, all of them will be marked as dirty and you will need to click "reload" in this annoying dialog, although it's perfectly clear (for the user) that no data will be lost.
>     This is not only annoying, but also makes the dialog less useful in cases where data loss would really occur, because you are so used to it popping up for nothing.

Hm, haven't used KDev for a while, but isn't it just a single dialog asking to reload all? Or at least there was a 'reload all' in the menu now and I believe when switching branches inside KDevelop this is even done for you.

Not saying this isn't useful, QtCreator asks me after switching branches wether I want to reload all documents or just this one or close it or so. And it does annoy me with one dialog per file that got removed due to the branch-switch. So if this can all be handled transparently if one uses git cli, I'm all for it.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113584/#review42873
-----------------------------------------------------------


On Nov. 2, 2013, 6:34 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113584/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2013, 6:34 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Milian Wolff.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> When a file is changed on disk, we can look in the git object repository
> and see whether the contents currently in the editor are stored somewhere
> there. In that case, there is no risk of data loss when we just silently
> reload the document; the user can always retrieve the old version from
> git.
> 
> For this purpose I added a new VCS interface which version control plugins
> can choose to implement if they are able and willing to provide this
> functionality. If a plugin does not implement the interface, the old
> behaviour is unaffected.
> 
> I implemented the interface for the git plugin and it seems to be working fine.
> There's two issues we might want to talk about:
>  - We can not retrieve the line ending mode from kate. Thus, currently it will
>    only work for files with \n line endings (old behaviour is used instead for
>    different line endings).
>  - It's not blazingly fast. It's not exactly slow, but if you have like 35
>    documents open, the freeze on switching to a completely different branch
>    is noticeable. Test it yourself and give your opinion on whether this
>    is acceptable or not.
> 
> 
> Diffs
> -----
> 
>   outputview/outputjob.h 83e9c1dec4f6ce9608ad330d5243e1991eda0cf7 
>   plugins/git/gitplugin.h 2f60c24b9d223a815eda6627d1328ce2404e11af 
>   plugins/git/gitplugin.cpp 27f4eaeea46afdfccb88d64caf161cc84a1e5bad 
>   shell/textdocument.cpp 187a071d78c3e2d00092bb2adde533486be11eee 
>   vcs/interfaces/icontentawareversioncontrol.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113584/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131102/00438c7a/attachment.html>