Review Request 110713: Show a status bar if VI mode is enabled
Sven Brauch
svenbrauch at gmx.de
Thu May 30 10:42:27 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110713/
-----------------------------------------------------------
(Updated May 30, 2013, 10:42 a.m.)
Review request for KDevelop.
Changes
-------
patch with try_compile instead of relying on KDE version
Description
-------
The kate people recently merged the vi mode status bar into the main editor status bar (which makes sense). We don't show that bar though, so the vi mode bar is missing. This patch adds it back in, by adding a custom label to the view which displays the vi mode and file name. See the thread [1] where this was discussed on kwrite-devel.
I'm aware that this is not the most elegant code ever but it gets the job done.
______
[1] http://lists.kde.org/?l=kwrite-devel&m=136499004230520&w=2
Diffs (updated)
-----
shell/CMakeLists.txt e9cf31f
shell/testeditvimode.cpp PRE-CREATION
shell/textdocument.h 1d31ad9
shell/textdocument.cpp 196dfaf
Diff: http://git.reviewboard.kde.org/r/110713/diff/
Testing
-------
seems to work ok, toggling vi mode, toggling mode inside vi mode (insert / normal etc) works
Thanks,
Sven Brauch
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130530/4b91be99/attachment.html>
More information about the KDevelop-devel
mailing list