Review Request 110713: Show a status bar if VI mode is enabled

[Sven Brauch]

> On May 29, 2013, 8:10 p.m., Andreas Pakulat wrote:
> > shell/textdocument.cpp, line 793
> > <http://git.reviewboard.kde.org/r/110713/diff/2/?file=146917#file146917line793>
> >
> >     Did you see adymo's comment about there being some status-bar-space at the right end of the bottom button's? I'm not sure that'll look good/right, but maybe worth a try.
> 
> Sven Brauch wrote:
>     Sorry, I don't know what you're referring to here. Which comment do you mean?
> 
> Andreas Pakulat wrote:
>     He replied on the mailinglist thread where we talked about the position of the vi-mode label. See http://mail.kde.org/pipermail/kdevelop-devel/2013-May/045402.html

I guess this corner is meant? http://i.imgur.com/0bxH0bi.png
That is not going to work in my opinion, since the information displayed is per-view, and you might have multiple views. On the other hand, we're just displaying the line number for the active view anyways (probably not a good idea either)...
Still, it sounds like introducing trouble to me.


> On May 29, 2013, 8:10 p.m., Andreas Pakulat wrote:
> > shell/textdocument.cpp, line 792
> > <http://git.reviewboard.kde.org/r/110713/diff/2/?file=146917#file146917line792>
> >
> >     Not sure you want to dive into this, but one could use cmake to try to do a compile-test with the header exposing the enum and a short snippet that uses the enum. If the compile-test succeeds the cmake code can set a define and else not set it so this code could be also enabled for people building kate+kte from git.
> >     
> >     I think there already is a config.h.in or so which has such defines in the kdevplatform root.
> 
> Sven Brauch wrote:
>     To be honest, I don't think it's worth it. The feature is very minor and if you compile yourself you can either update everything, or just live without that display. I don't think it even qualifies as a defect, for that matter ;)
>     And cmake compile tests are a bit of a hassle, aren't they... like, you need an extra directory with an extra cmake file and whatnot...
>     If you really think it's worth it I'll take it as an opportunity and learn how it works, but I'd say it's not :)
> 
> Andreas Pakulat wrote:
>     I think you misunderstood a bit. Kate and its KTextEditor code can be build and installed these days from the git repository. They can be installed into a location other than the install-directory of kdelibs and still override the kdelibs-shipped katepart/ktexteditor. I'm using such a setup here and it allows me to ignore the fact that I have a 2 years old kdelibs installed and can't upgrade that at the moment. Compiling kdelibs from sources is not an option for me, thats simply too much effort. But I don't use the vi-mode either, so just wanted to clarify that these days there might be quite some users out there using latest-kate/kte with an older kdelibs.
>     
>     I don't know where you got the impression that cmake compile tests need an extra directory, you can use try_compile with just a source file as well. Something like this with a bit of tweaking for the includedirs/libraries should work:
>     
>     try_compile( HAS_EDITVIMODE ${CMAKE_OUTPUT_DIRECTORY} ${CMAKE_SOURCE_DIRECTORY}/testeditvimode.cpp
>                  CMAKE_FLAGS "-DINCLUDE_DIRECTORIES=${KDE_INCLUDES}" "-DLINK_LIBRARIES=${KDE_LIBRARIES}" )

Ok, I'll submit a version which does this shortly.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110713/#review33376
-----------------------------------------------------------


On May 29, 2013, 9:43 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110713/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 9:43 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The kate people recently merged the vi mode status bar into the main editor status bar (which makes sense). We don't show that bar though, so the vi mode bar is missing. This patch adds it back in, by adding a custom label to the view which displays the vi mode and file name. See the thread [1] where this was discussed on kwrite-devel.
> I'm aware that this is not the most elegant code ever but it gets the job done.
> 
> ______
> [1] http://lists.kde.org/?l=kwrite-devel&m=136499004230520&w=2
> 
> 
> Diffs
> -----
> 
>   shell/textdocument.h 1d31ad9 
>   shell/textdocument.cpp 196dfaf 
> 
> Diff: http://git.reviewboard.kde.org/r/110713/diff/
> 
> 
> Testing
> -------
> 
> seems to work ok, toggling vi mode, toggling mode inside vi mode (insert / normal etc) works
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130530/0c096816/attachment-0001.html>