Review Request 110584: CodeHighlighting => ICodeHighlighting

[Andrea Scarpino]

> On May 21, 2013, 11:14 p.m., Andrea Scarpino wrote:
> > I'm not sure this is needed. CodeHighlighting is an interface and you only sets types here.
> 
> Vyacheslav Blinov wrote:
>     Yes, it is, but I belive it's always better to choose lowest level class if you can and there is no mess cause of it. And in this code you can.

I'm sorry, but I believe highest is better.

We've to wait someone else opinion ;)


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110584/#review32934
-----------------------------------------------------------


On May 21, 2013, 10:36 p.m., Vyacheslav Blinov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110584/
> -----------------------------------------------------------
> 
> (Updated May 21, 2013, 10:36 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Due to signature change and class rename
> 
> 
> Diffs
> -----
> 
>   javalanguagesupport.h d8c8442 
> 
> Diff: http://git.reviewboard.kde.org/r/110584/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vyacheslav Blinov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130521/cc81ad7e/attachment.html>