Review Request 110580: Optimize: Cache initial cmake variables

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110580/
-----------------------------------------------------------

(Updated May 21, 2013, 6:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop and Aleix Pol Gonzalez.


Description
-------

Do not call `cmake --system-information` for every project - cache it instead. On my system this call takes ~1s and thus in my favorite session this slows down startup by ~5-10s (1s for every project I have open in that project).

I post the review request here because I'm not sure whether there are use cases where we do not want this behavior. Like a system upgrade where system information variables changed. But then again - we don't actually reload the project there anyways... So - is this OK? Aleix?

Also - should this maybe also use the cmake binary configured for a given project? That would be for a different patch then of course. Just interested.


Diffs
-----

  projectmanagers/cmake/parser/cmakeparserutils.cpp 805e6f4 

Diff: http://git.reviewboard.kde.org/r/110580/diff/


Testing
-------

Ran the stuff. Seems to work :]


Thanks,

Milian Wolff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130521/6dfcce67/attachment.html>