Review Request 110068: Add support for Clang/Clang++ in build output view

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110068/#review32604
-----------------------------------------------------------


This review has been submitted with commit 61d32ab3f4f273dadf445a11eff1cd26b7eb1a92 by Kevin Funk to branch master.

- Commit Hook


On April 17, 2013, 8:11 p.m., Torbjoern Klatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110068/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 8:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Up to now, if a target is build with clang++, the used compiler stated in the build output view was 'g++'. That's obviously wrong and misleading.
> 
> This patch adds 'clang' and 'clang++' to the list of detected compilers in the filtered build output view. As I'm developing both with g++ and clang++, it kept confusing me whether I triggered a build in the correct/desired build environment.
> 
> This is related to Bug #240017 though it does not target 'mpicc', which still gets displayed as 'icc'. Also obviously wrong and misleading.
> 
> In the future, the method for extracting the compiler in the build output should be changed from a hard-coded regex to a more configurable method.
> 
> 
> This addresses bug 240017.
>     http://bugs.kde.org/show_bug.cgi?id=240017
> 
> 
> Diffs
> -----
> 
>   outputview/outputfilteringstrategies.cpp bdf6ffc 
> 
> Diff: http://git.reviewboard.kde.org/r/110068/diff/
> 
> 
> Testing
> -------
> 
> Tested by triggering builds in two different build environments with both g++ and clang++.
> 
> 
> Thanks,
> 
> Torbjoern Klatt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130515/3f1d66f8/attachment.html>