Review Request 110422: Changes to the cmake_qt4core_qtest template

[Adrián Chaves Fernández]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110422/
-----------------------------------------------------------

(Updated May 14, 2013, 6:41 p.m.)


Review request for KDevelop.


Changes
-------

Replaced the original patch with one that just fixed the actual issue:
* Added ${QT_QTCORE_LIBRARY} to the target_link_libraries() CMake command of the tests. It would not build here otherwise.


Description
-------

I’ve performed the following changes on the template:
* Moved the source files into an ‘src’ folder, instead of having them in the main folder.
* Added a missing ${QT_QTCORE_LIBRARY} to the test’s target_link_libraries() CMake command which was preventing the template to build here.
* Specified the QtCore and QtTest components in the find() CMake command.

Note: I do *not* have commit access.


Diffs (updated)
-----

  app_templates/cpp/CMake/cmake_qt4core_qtest/tests/CMakeLists.txt 42ccb9b 

Diff: http://git.reviewboard.kde.org/r/110422/diff/


Testing
-------


Thanks,

Adrián Chaves Fernández

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130514/02ca340d/attachment.html>