Review Request 110422: Changes to the cmake_qt4core_qtest template

[Aleix Pol Gonzalez]

> On May 14, 2013, 6:43 a.m., Andreas Pakulat wrote:
> > Why did you move the files into a src/ subfolder? I don't see any reason for doing that and it breaks consistency with the other templates we ship.
> 
> Adrián Chaves Fernández wrote:
>     I think that is the most common way of distributing the source files. Anyway, I don’t mind if you close the request. Just make sure you guys apply the 2nd point of my changes: “Added a missing ${QT_QTCORE_LIBRARY} to the tests’ target_link_libraries() CMake command which was preventing the template to build here”.

Hi Adrián, can you please provide a stripped down version of the patch? If you really think it should have an src/ we can change it later on, but let's do 1 change at a time (or no fixes and features mixed up).


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110422/#review32482
-----------------------------------------------------------


On May 14, 2013, 5:42 a.m., Adrián Chaves Fernández wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110422/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 5:42 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I’ve performed the following changes on the template:
> * Moved the source files into an ‘src’ folder, instead of having them in the main folder.
> * Added a missing ${QT_QTCORE_LIBRARY} to the test’s target_link_libraries() CMake command which was preventing the template to build here.
> * Specified the QtCore and QtTest components in the find() CMake command.
> 
> Note: I do *not* have commit access.
> 
> 
> Diffs
> -----
> 
>   app_templates/cpp/CMake/cmake_qt4core_qtest/%{APPNAME}.h 2d49681 
>   app_templates/cpp/CMake/cmake_qt4core_qtest/%{APPNAME}.cpp b3df437 
>   app_templates/cpp/CMake/cmake_qt4core_qtest/CMakeLists.txt 5e83972 
>   app_templates/cpp/CMake/cmake_qt4core_qtest/main.cpp 426830e 
>   app_templates/cpp/CMake/cmake_qt4core_qtest/src/%{APPNAME}.h PRE-CREATION 
>   app_templates/cpp/CMake/cmake_qt4core_qtest/src/%{APPNAME}.cpp PRE-CREATION 
>   app_templates/cpp/CMake/cmake_qt4core_qtest/src/CMakeLists.txt PRE-CREATION 
>   app_templates/cpp/CMake/cmake_qt4core_qtest/src/main.cpp PRE-CREATION 
>   app_templates/cpp/CMake/cmake_qt4core_qtest/tests/CMakeLists.txt 42ccb9b 
> 
> Diff: http://git.reviewboard.kde.org/r/110422/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adrián Chaves Fernández
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130514/b926a6e8/attachment.html>