Review Request 110422: Changes to the cmake_qt4core_qtest template
Adrián Chaves Fernández
adriyetichaves at gmail.com
Tue May 14 05:40:54 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110422/
-----------------------------------------------------------
Review request for KDevelop.
Description
-------
I’ve performed the following changes on the template:
* Moved the source files into an ‘src’ folder, instead of having them in the main folder.
* Added a missing ${QT_QTCORE_LIBRARY} to the test’s target_link_libraries() CMake command which was preventing the template to build here.
* Specified the QtCore and QtTest components in the find() CMake command.
Diffs
-----
app_templates/cpp/CMake/cmake_qt4core_qtest/%{APPNAME}.h 2d49681
app_templates/cpp/CMake/cmake_qt4core_qtest/%{APPNAME}.cpp b3df437
app_templates/cpp/CMake/cmake_qt4core_qtest/CMakeLists.txt 5e83972
app_templates/cpp/CMake/cmake_qt4core_qtest/main.cpp 426830e
app_templates/cpp/CMake/cmake_qt4core_qtest/src/%{APPNAME}.h PRE-CREATION
app_templates/cpp/CMake/cmake_qt4core_qtest/src/%{APPNAME}.cpp PRE-CREATION
app_templates/cpp/CMake/cmake_qt4core_qtest/src/CMakeLists.txt PRE-CREATION
app_templates/cpp/CMake/cmake_qt4core_qtest/src/main.cpp PRE-CREATION
app_templates/cpp/CMake/cmake_qt4core_qtest/tests/CMakeLists.txt 42ccb9b
Diff: http://git.reviewboard.kde.org/r/110422/diff/
Testing
-------
Thanks,
Adrián Chaves Fernández
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130514/8a7d670b/attachment.html>
More information about the KDevelop-devel
mailing list