Review Request 110374: Add support for php 5.4's short array syntax.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110374/#review32382
-----------------------------------------------------------


please also add unit tests, similar to e.g. TestExpressionParser::array to verify that this is properly parsed and interpreted as an array.

- Milian Wolff


On May 9, 2013, 3:59 p.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110374/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 3:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> A first step towards support for the new syntax features introduced in PHP 5.4.
> This implements parsing support for the short (json-style) array syntax where one can rewrite
> 
> $var = array( "key" => "value" );
> 
> as
> 
> $var = [ "key" => "value" ];
> 
> 
> This addresses bug 305779.
>     http://bugs.kde.org/show_bug.cgi?id=305779
> 
> 
> Diffs
> -----
> 
>   parser/php.g ad60514c22795cbc1aa16a7fc8de2ea696859487 
> 
> Diff: http://git.reviewboard.kde.org/r/110374/diff/
> 
> 
> Testing
> -------
> 
> I tested this locally with kdevplatform 1.5.0 and kdevelop 4.5.0.
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130512/b70d199b/attachment.html>