Review Request 110380: kdev-php: Use user-selected indentation in code completion

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110380/#review32381
-----------------------------------------------------------



completion/helpers.cpp
<http://git.reviewboard.kde.org/r/110380/#comment24088>

    also check whether iface is valid


- Milian Wolff


On May 10, 2013, 8:14 a.m., Miquel Sabaté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110380/
> -----------------------------------------------------------
> 
> (Updated May 10, 2013, 8:14 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Now that we can read the indentation settings ( http://quickgit.kde.org/?p=kate.git&a=commit&h=fbeecb7384e3c3986e8fbafa1123aa422d97e537 ), we can use it for the code completion. If you compile against a version of Kate older than the specified commit, then the indentation used is the same as it was before this patch (4 spaces).
> 
> 
> Diffs
> -----
> 
>   completion/helpers.h b8721b1 
>   completion/helpers.cpp dfc5bc6 
>   completion/keyworditem.cpp 8eec9a7 
> 
> Diff: http://git.reviewboard.kde.org/r/110380/diff/
> 
> 
> Testing
> -------
> 
> All Code completion tests are passing.
> 
> 
> Thanks,
> 
> Miquel Sabaté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130512/10f5090b/attachment.html>