Review Request 110298: added kdevplatform part of kdevelop zsh integration

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110298/#review32038
-----------------------------------------------------------


Whats the idea here? Are you intending to run kdevelop on a system without bash? While I can understand that, it'll not be possible to maintain n different versions of the shell script for n different shells. Changes to it are seldom, but that just means its more important someone actively watches the bash version and adapts the zsh variant.


util/.zshrc
<http://git.reviewboard.kde.org/r/110298/#comment23868>

    Where is the zsh-specific version of this file? AFAIK that file is not adhering to posix sh compatible shell behaviour, so it can contain bashisms. Hence you'd need a zsh variant and that needs to be maintained over time.



util/CMakeLists.txt
<http://git.reviewboard.kde.org/r/110298/#comment23865>

    Please avoid unrelated whitespace changes.
    
    What might make sense though if the permissions and destination are the same for these files is to have just a single install() call with all of the files.



util/kdevplatform_shell_environment.sh
<http://git.reviewboard.kde.org/r/110298/#comment23866>

    If you don't want a login shell as the comment above says, this line is wrong. Bash only reads .bash_profile when its invoked as login shell.



util/kdevplatform_shell_environment.sh
<http://git.reviewboard.kde.org/r/110298/#comment23867>

    Same thing here, .profile is only read by bash for login shells.


- Andreas Pakulat


On May 4, 2013, 2:23 p.m., Phil Schaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110298/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 2:23 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> added kdevplatform part of kdevelop zsh integration
> 
> sister review of https://git.reviewboard.kde.org/r/110299/
> 
> 
> Diffs
> -----
> 
>   util/.zshrc PRE-CREATION 
>   util/CMakeLists.txt 29de12617b4e9d7697abc73465ed435b9039c531 
>   util/kdevplatform_shell_environment.sh d2ece7f9286f8cb8ae35c672a29d5248e2c1a199 
> 
> Diff: http://git.reviewboard.kde.org/r/110298/diff/
> 
> 
> Testing
> -------
> 
> I don’t know if $OLD_ZDOTDIR gets carried over to “kdevplatform_shell_environment.sh” through “.zshrc”!
> 
> can someone help here?
> 
> 
> Thanks,
> 
> Phil Schaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130504/da7f6820/attachment-0001.html>