Review Request 103904: Bug 274299 - JJ: explanation on failed snippet name validation required

[Ghislain Mary]

> On March 31, 2013, 1:07 a.m., Aleix Pol Gonzalez wrote:
> > I see in bugzilla that this was reverted because it required a too new version of kdelibs. Should we maybe revise it?

http://techbase.kde.org/KDevelop4/Compatibility tells that KDevelop 4.2 and later versions require at least kdelibs 4.5.2.
But it seems this page is not really up-to-date. So what is the minimum kdelibs requirement for KDevelop 4.5?


- Ghislain


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103904/#review30168
-----------------------------------------------------------


On Feb. 10, 2012, 11:44 a.m., Ghislain Mary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103904/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2012, 11:44 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Show a warning message in a KMessageWidget if a space character is entered in the snippet name line edit.
> 
> 
> This addresses bug 274299.
>     http://bugs.kde.org/show_bug.cgi?id=274299
> 
> 
> Diffs
> -----
> 
>   plugins/snippet/editsnippet.cpp 732c52a71967ff6d2eea131f854d92f3f2b19ccf 
>   plugins/snippet/editsnippet.ui bb48e5e8570e37e2b53a2b69971d76ee201f0742 
> 
> Diff: http://git.reviewboard.kde.org/r/103904/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Patch created with "git format-patch" and with wording fix
>   http://git.reviewboard.kde.org/media/uploaded/files/2012/02/10/0001-Bug-274299-JJ-explanation-on-failed-snippet-name-val.patch
> 
> 
> Thanks,
> 
> Ghislain Mary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130503/ed204a9e/attachment.html>