Review Request 109653: Display long branch names correctly (git plugin)
Aleix Pol Gonzalez
aleixpol at gmail.com
Fri Mar 22 13:38:53 UTC 2013
> On March 22, 2013, 12:12 p.m., Aleix Pol Gonzalez wrote:
> > The patch is correct. The command that gets the current branch changed recently, but the parsing wasn't changed.
>
> Alexander Mezin wrote:
> I don't have commit rights, so you have to commit it.
>
> Andreas Pakulat wrote:
> Ah, right, I overlooked the surrounding changes and of course misrembered the semantics of QString::right.
Alexander, can you send me a formatted patch? This way you'll stay as the author of the patch.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109653/#review29702
-----------------------------------------------------------
On March 22, 2013, 10:06 a.m., Alexander Mezin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109653/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 10:06 a.m.)
>
>
> Review request for KDevelop and Aleix Pol Gonzalez.
>
>
> Description
> -------
>
> Git plugin did strange things with current branch name.
> I had a branch with long name, and KDevelop displayed only 2 last chars.
>
>
> Diffs
> -----
>
> plugins/git/gitplugin.cpp c873081
>
> Diff: http://git.reviewboard.kde.org/r/109653/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Mezin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130322/5c2d9364/attachment-0001.html>
More information about the KDevelop-devel
mailing list