Review Request 109612: Splashscreen part 2: give startup progress information

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109612/#review29613
-----------------------------------------------------------


Well, making a Class and its Private is a much smaller change than adding public API that nobody else should use (which someone may end up not knowing/forgetting and do nonetheless).


shell/core.h
<http://git.reviewboard.kde.org/r/109612/#comment22084>

    Still an uneeded forward declaration here.



shell/core.h
<http://git.reviewboard.kde.org/r/109612/#comment22085>

    And this function should be removed now.


- Andreas Pakulat


On March 21, 2013, 1:08 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109612/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 1:08 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This belongs to https://git.reviewboard.kde.org/r/109610/.
> It emits a few (~10) signals from the kdev core when it's starting up, which can then be caught by the splash screen to display a progress bar.
> 
> 
> Diffs
> -----
> 
>   shell/core.h d7ba435 
>   shell/core.cpp 91a5630 
> 
> Diff: http://git.reviewboard.kde.org/r/109612/diff/
> 
> 
> Testing
> -------
> 
> I don't see what could go wrong here.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130321/7d4d8f0e/attachment.html>