Review Request 109569: Target compile definitions may have values.

[Ben Wagner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109569/
-----------------------------------------------------------

(Updated March 19, 2013, 5:27 a.m.)


Review request for KDevelop.


Changes
-------

Now with a test.


Description
-------

The documentation at http://www.cmake.org/cmake/help/v2.8.8/cmake.html#prop_dir:COMPILE_DEFINITIONS states that COMPILE_DEFINITIONS is a list of VAR or VAR=value. When COMPILE_DEFINITIONS is set on a target, KDevelop currently only handles the 'VAR' case, but in the 'VAR=value' case makes the name of the define 'VAR=value' and sets the value to ''. This fixes that.


Diffs (updated)
-----

  projectmanagers/cmake/cmakemodelitems.cpp 3665ac4 
  projectmanagers/cmake/tests/cmakemanagertest.h 7526d4c 
  projectmanagers/cmake/tests/cmakemanagertest.cpp cd2a459 
  projectmanagers/cmake/tests/manual/target_defines/CMakeLists.txt PRE-CREATION 
  projectmanagers/cmake/tests/manual/target_defines/main.cpp PRE-CREATION 
  projectmanagers/cmake/tests/manual/target_defines/target_defines.kdev4 PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109569/diff/


Testing
-------

Built and ran, now the correct defines show in pop-ups and the correct code is parsed for editing.


File Attachments (updated)
----------------

format-diff
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/0001-Target-compile-definitions-may-have-values.patch


Thanks,

Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130319/76a513ac/attachment-0001.html>