Review Request 109569: Target compile definitions may have values.

Ben Wagner bungeman at
Tue Mar 19 05:28:00 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated March 19, 2013, 5:27 a.m.)

Review request for KDevelop.


Now with a test.


The documentation at states that COMPILE_DEFINITIONS is a list of VAR or VAR=value. When COMPILE_DEFINITIONS is set on a target, KDevelop currently only handles the 'VAR' case, but in the 'VAR=value' case makes the name of the define 'VAR=value' and sets the value to ''. This fixes that.

Diffs (updated)

  projectmanagers/cmake/cmakemodelitems.cpp 3665ac4 
  projectmanagers/cmake/tests/cmakemanagertest.h 7526d4c 
  projectmanagers/cmake/tests/cmakemanagertest.cpp cd2a459 
  projectmanagers/cmake/tests/manual/target_defines/CMakeLists.txt PRE-CREATION 
  projectmanagers/cmake/tests/manual/target_defines/main.cpp PRE-CREATION 
  projectmanagers/cmake/tests/manual/target_defines/target_defines.kdev4 PRE-CREATION 



Built and ran, now the correct defines show in pop-ups and the correct code is parsed for editing.

File Attachments (updated)



Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list