Review Request 109554: Fix issue in grepview plugin

Commit Hook null at kde.org
Tue Mar 19 20:54:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109554/
-----------------------------------------------------------

(Updated March 19, 2013, 8:54 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Description
-------

Fix issue in grepview plugin

It was impossible to replace "\n" with "\n\n" before.

I really don't know what the code path replacing '\\' by '\\\\'
was supposed to do. The replacement happened depending on how to the *search* was
performed -- but this has nothing do with how the *replace* is performed(?)

Add tests.

BUG: 301362


This addresses bug 301362.
    http://bugs.kde.org/show_bug.cgi?id=301362


Diffs
-----

  plugins/grepview/grepoutputmodel.cpp b1784a374417a34fac8fe8d409f752eadac62aa0 
  plugins/grepview/tests/findreplacetest.cpp dcb14aaec4b05c979181902614ea34fc8d977daf 

Diff: http://git.reviewboard.kde.org/r/109554/diff/


Testing
-------


Thanks,

Kevin Funk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130319/89d1c98e/attachment.html>


More information about the KDevelop-devel mailing list