Review Request 109562: When a user has ( in the project name, use an alternative

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109562/#review29489
-----------------------------------------------------------


What Kevin said, adding QTextDocument is totally unneeded here.

Also is there a particular reason you went with italic instead of greying out the font? I think having the branch name there with full color adds too much noise and distracts too much from the actual information. In particular when this is being used to add more vcs-information to the rest of the files (like the revision because thats possible with svn or for git submodules).

- Andreas Pakulat


On March 19, 2013, 1:13 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109562/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 1:13 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> If there's ( in the project name, use [.
> 
> Then it will look like "Project Name (some thing) [master]".
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/CMakeLists.txt 93971e2 
>   plugins/projectmanagerview/projectmodelitemdelegate.h PRE-CREATION 
>   plugins/projectmanagerview/projectmodelitemdelegate.cpp PRE-CREATION 
>   plugins/projectmanagerview/projecttreeview.cpp 4f9b5ae 
>   plugins/projectmanagerview/vcsoverlayproxymodel.cpp b414868 
> 
> Diff: http://git.reviewboard.kde.org/r/109562/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Result
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/18/kdevelop-peoplehaveparenthesisinprojectnames.png
> custom delegate
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/kdevelop-peoplehaveparenthesisinprojectnames1.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130319/06e042f9/attachment.html>