Review Request 109569: Target compile definitions may have values.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109569/#review29469
-----------------------------------------------------------

Ship it!


Good catch!

Can you please add a unit test for checking this?

- Aleix Pol Gonzalez


On March 18, 2013, 7:18 p.m., Ben Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109569/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 7:18 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The documentation at http://www.cmake.org/cmake/help/v2.8.8/cmake.html#prop_dir:COMPILE_DEFINITIONS states that COMPILE_DEFINITIONS is a list of VAR or VAR=value. When COMPILE_DEFINITIONS is set on a target, KDevelop currently only handles the 'VAR' case, but in the 'VAR=value' case makes the name of the define 'VAR=value' and sets the value to ''. This fixes that.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/cmakemodelitems.cpp 3665ac4 
> 
> Diff: http://git.reviewboard.kde.org/r/109569/diff/
> 
> 
> Testing
> -------
> 
> Built and ran, now the correct defines show in pop-ups and the correct code is parsed for editing.
> 
> 
> File Attachments
> ----------------
> 
> format-diff
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/18/0001-Target-compile-definitions-may-have-values.patch
> 
> 
> Thanks,
> 
> Ben Wagner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130318/f531ade1/attachment-0001.html>