Review Request 109562: When a user has ( in the project name, use an alternative

[Andreas Pakulat]

> On March 18, 2013, 12:37 p.m., Andreas Pakulat wrote:
> > I think its much more useful to use a slightly greyed out font. It much more clearly distinguishes the meta-information from the actual project name.
> > 
> > Since the KDevelop project names are free-form, what happens if I use () and [] for some reason?
> 
> Aleix Pol Gonzalez wrote:
>     That's a Qt limitation. You can't put rich text in a delegate.
>     The suggested alternative is to have a QLabel in the delegate, which I don't think we want.
>     
>     If () and [] are used, () is used.

Can you please re-read the related mailinglist thread and the Qt Labs article that was linked there? Nobody suggests to use richtext, simply use a delegate to fetch the vcs-data as a separate role and draw that differently.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109562/#review29439
-----------------------------------------------------------


On March 18, 2013, 11:15 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109562/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 11:15 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> If there's ( in the project name, use [.
> 
> Then it will look like "Project Name (some thing) [master]".
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/vcsoverlayproxymodel.cpp b414868 
> 
> Diff: http://git.reviewboard.kde.org/r/109562/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Result
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/18/kdevelop-peoplehaveparenthesisinprojectnames.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130318/dfc6eb13/attachment.html>