Review Request 109547: Annotation toggle behaviour

Sven Brauch svenbrauch at gmx.de
Sun Mar 17 15:46:54 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109547/#review29383
-----------------------------------------------------------

Ship it!


Good change, just remove the newline you added at the end of the file imo, it's unrelated.

- Sven Brauch


On March 17, 2013, 3:30 p.m., Przemek Czekaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109547/
> -----------------------------------------------------------
> 
> (Updated March 17, 2013, 3:30 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Those patch, add functionality as toggle for KAction "Annotation" in KDevelop.
> 
> 
> Diffs
> -----
> 
>   vcs/vcspluginhelper.cpp 10e3b53 
> 
> Diff: http://git.reviewboard.kde.org/r/109547/diff/
> 
> 
> Testing
> -------
> 
> Manualy check, click on "Annotation" in Git KAction, then Annotation bar will show, next time when you click on this KAction, Annotation bar will hide self. Before this patch, Annotation bar, close and reopen self again.
> 
> 
> Thanks,
> 
> Przemek Czekaj
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130317/1d04a0d8/attachment.html>


More information about the KDevelop-devel mailing list