Review Request 109537: Use filterdeclaration on loohahead results
Olivier Jean de Gaalon
olivier.jg at gmail.com
Sun Mar 17 21:09:44 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109537/
-----------------------------------------------------------
(Updated March 17, 2013, 9:09 p.m.)
Review request for KDevelop.
Changes
-------
Address issues
Description
-------
This patch calls filterdeclaration on lookahead results so that it doesn't offer members that aren't visible in the current scope, plus tests.
Had to also make some changes for const-correctness in order to call filterdeclaration.
Diffs (updated)
-----
languages/cpp/codecompletion/context.h ce77e94
languages/cpp/codecompletion/context.cpp 1d109d8
languages/cpp/tests/test_cppcodecompletion.cpp 90c2715
Diff: http://git.reviewboard.kde.org/r/109537/diff/
Testing
-------
Unit testing, casual testing.
Thanks,
Olivier Jean de Gaalon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130317/ba96d768/attachment.html>
More information about the KDevelop-devel
mailing list