Review Request 109532: Prettify Branch Manager dialog

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109532/#review29390
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On March 16, 2013, 11:35 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109532/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 11:35 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> Consists of multiple commits:
> 
> BranchesListModel: Fix UI bug
> 
> BranchesListModel::setData never called the base-class implementation,
> hence setIcon() and setData() for roles != Qt::EditRole never had an
> effect.
> 
> Prettify Branch Manager dialog
> 
> Changes:
> * Double click now checks out the branch instead of starting a rename
> * Add extra button for the rename action
> * Add icons to the buttons
> * Set window title
> 
> GitPlugin: Hide '(no branch)' in branch list
> 
> Do not crash in BranchManager when detached
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitplugin.cpp e2f9f1980c8a006128ce6ecce4e88f1f9964d715 
>   vcs/dvcs/ui/branchmanager.h 62e3926bc4db9e8e422d5b38cbf418fc1f1b47d5 
>   vcs/dvcs/ui/branchmanager.cpp a19fd473a71efcd5faf2d2755f6397d0d0e8857f 
>   vcs/dvcs/ui/branchmanager.ui db8ebc422856a6a5c5ef375b98e1bc2e40e1a070 
>   vcs/models/brancheslistmodel.cpp 33b089ec4b3d430daec8b22053e2cf55ba64a17f 
> 
> Diff: http://git.reviewboard.kde.org/r/109532/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of new Branch Manager dialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/16/kdevelop_branches_new.png
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130317/968af672/attachment.html>