Review Request 109537: Use filterdeclaration on loohahead results

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109537/#review29385
-----------------------------------------------------------

Ship it!


Sounds good.

BTW: Are you also fine with me disabling this feature for 4.5? Afaik you agreed last time we talked about it. There are still a few places where this code completion feature adds too many items. I'll try to report bugs about them as well now if I find the cases I meant.


languages/cpp/codecompletion/context.cpp
<http://git.reviewboard.kde.org/r/109537/#comment21953>

    push that to the header and use it there as well, no?


- Milian Wolff


On March 17, 2013, 1:01 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109537/
> -----------------------------------------------------------
> 
> (Updated March 17, 2013, 1:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch calls filterdeclaration on lookahead results so that it doesn't offer members that aren't visible in the current scope, plus tests.
> Had to also make some changes for const-correctness in order to call filterdeclaration.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codecompletion/context.h ce77e94 
>   languages/cpp/codecompletion/context.cpp 1d109d8 
>   languages/cpp/tests/test_cppcodecompletion.cpp 90c2715 
> 
> Diff: http://git.reviewboard.kde.org/r/109537/diff/
> 
> 
> Testing
> -------
> 
> Unit testing, casual testing.
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130317/3fa3ab14/attachment.html>