Review Request 108908: Add menu action and shortcut for switch to buddy plugin

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108908/#review29142
-----------------------------------------------------------



interfaces/ibuddydocumentfinder.h
<http://git.reviewboard.kde.org/r/108908/#comment21758>

    Unrelated change. A vector is still a list.



interfaces/ibuddydocumentfinder.h
<http://git.reviewboard.kde.org/r/108908/#comment21759>

    Keep "list".



plugins/switchtobuddy/switchtobuddyplugin.cpp
<http://git.reviewboard.kde.org/r/108908/#comment21760>

    I would prefer if this shortcut would be implemented properly from the start such that it supports multiple files.
    
    It should cycle through buddies, similar to what the document switcher is doing for opened files.
    
    E.g.:
    
    (1) bar.h
    (2) bar.cpp
    (3) bar_p.h
    
    Then hitting the shortcut should jump from 1 to 2 to 3 to 1 and so forth. Also add a shortcut to jump in the reverse order, i.e. from 1 to 3 to 2 to 1.



plugins/switchtobuddy/switchtobuddyplugin.cpp
<http://git.reviewboard.kde.org/r/108908/#comment21761>

    rename to switchToBuddy(), function overloading will take care to call the proper function depending on the arguments.



plugins/switchtobuddy/switchtobuddyplugin.cpp
<http://git.reviewboard.kde.org/r/108908/#comment21762>

    rename to buddiesForDocument
    
    rename currentUrl to documentUrl or just url.


- Milian Wolff


On March 8, 2013, 10:50 a.m., André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108908/
> -----------------------------------------------------------
> 
> (Updated March 8, 2013, 10:50 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> As Milian suggested some time ago I implemented a menu action (in the Navigation menu) which allows swichting to the buddy document. A global action has been added too which allows to specify a shortcut for that action (Ctrl+Shift+s per default).
> 
> As I don't have much time right now I didn't implement Milian's idea to display a document switcher window when multiple buddies are available. Right now the plugin just switches to the first, "primary" buddy document.
> 
> 
> Diffs
> -----
> 
>   plugins/switchtobuddy/switchtobuddyplugin.cpp 2a3073a 
>   plugins/switchtobuddy/switchtobuddyplugin.h efa7f1e 
>   plugins/switchtobuddy/kdevswitchtobuddy.rc PRE-CREATION 
>   interfaces/ibuddydocumentfinder.h 05fb7ee 
>   plugins/switchtobuddy/CMakeLists.txt 795b5ed 
> 
> Diff: http://git.reviewboard.kde.org/r/108908/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> André Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130313/1935cfbd/attachment-0001.html>