Review Request 109317: Don't upload/download the file project if it's local

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109317/#review28736
-----------------------------------------------------------



shell/project.cpp
<http://git.reviewboard.kde.org/r/109317/#comment21479>

    I'd move this assignment into the else branch, there's no point in having it in the more public scope.


Alas, I don't think this is a proper fix for the bug. The same thing can happen with actual remote projects. We should simply do a synchronization "every once in a while" or maybe even whenever the apply button is clicked in the project config dialog (or something else in the kconfig-object is saved).

I also don't like treating local files differently to remote ones here, KIO makes this all completely transparent and thats a good thing and all other places

I don't have strong objections though, so if it fixes an annoying bug and you can move the above object-creation I think it can go in.

- Andreas Pakulat


On March 6, 2013, 7:30 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109317/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 7:30 p.m.)
> 
> 
> Review request for KDevelop and Andreas Pakulat.
> 
> 
> Description
> -------
> 
> See the bug attached.
> 
> It's of no use that we keep sync'ing the config files if they have to be moved around in the end.
> 
> What this patch does, is to not have a developerTempFile and instead use the actual developer config file (the .kdev4/*.kdev4) to read/write configurations, in case it's a local project.
> 
> 
> This addresses bug 291983.
>     http://bugs.kde.org/show_bug.cgi?id=291983
> 
> 
> Diffs
> -----
> 
>   shell/project.cpp b0fb221 
> 
> Diff: http://git.reviewboard.kde.org/r/109317/diff/
> 
> 
> Testing
> -------
> 
> Restarted some kdevelop cmake projects and it seemed to work.
> 
> Also tests didn't stop working, although it seems unlikely that anything depends on that.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130306/1719732b/attachment.html>