Review Request 111194: Fix incorrect path to qt documentation.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111194/#review34963
-----------------------------------------------------------


small coding style nitpicks, then this is ready to go - many thanks!


documentation/qthelp/qthelpqtdoc.cpp
<http://git.reviewboard.kde.org/r/111194/#comment25597>

    I'd add the trimmed after the p->readAllStandardOutput()



documentation/qthelp/qthelpqtdoc.cpp
<http://git.reviewboard.kde.org/r/111194/#comment25598>

    While this line will be removed if you add it to the line above, generally please add whitespaces around operators (like +, =, ...)



documentation/qthelp/qthelpqtdoc.cpp
<http://git.reviewboard.kde.org/r/111194/#comment25599>

    here e.g. please add whitespaces around the '+' operator.



documentation/qthelp/qthelpqtdoc.cpp
<http://git.reviewboard.kde.org/r/111194/#comment25600>

    please use this coding style:
    
    if() {
       ...
    } else {
       ...
    }


- Milian Wolff


On June 23, 2013, 8:04 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111194/
> -----------------------------------------------------------
> 
> (Updated June 23, 2013, 8:04 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> QtHelpQtDoc can't load qt documentation because of incorrectly formed path, like "/usr/share/qt4/doc\n/qch/..."
> 
> 
> Diffs
> -----
> 
>   documentation/qthelp/qthelpqtdoc.cpp fa1b59e 
> 
> Diff: http://git.reviewboard.kde.org/r/111194/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130624/cf3fe1b0/attachment.html>