Review Request 111133: Proper support of FORCE statement in cmake set
Commit Hook
null at kde.org
Wed Jun 19 23:45:55 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111133/
-----------------------------------------------------------
(Updated June 19, 2013, 11:45 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDevelop.
Description
-------
_qt4_find_qmake is recursive function which uses two conditions to stop recursion. One of them relies on changing of QT_QMAKE_EXECUTABLE cached variable using forced set. This commit handles forced set syntax correctly. Partially related to https://bugs.kde.org/show_bug.cgi?id=320875
Diffs
-----
projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 5299b7c
Diff: http://git.reviewboard.kde.org/r/111133/diff/
Testing
-------
manually tested with extra logs
Thanks,
Sergey Vidyuk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130619/b7dea86d/attachment-0001.html>
More information about the KDevelop-devel
mailing list