Review Request 111132: Squeeze/Elide session's description

[Andrea Scarpino]

> On June 19, 2013, 9:15 p.m., Àlex Fiestas wrote:
> > Can we put the elided at the end? they don't make sense in the middle I think.

Yes, the version pushed elide the text at the end.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111132/#review34703
-----------------------------------------------------------


On June 19, 2013, 7:58 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111132/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 7:58 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> When a session contains many projects, or projects with very long titles, the Session->Menu width expands to contains the whole description.
> See the first screenshot, that's the *whole* screen.
> 
> I used KStringHandler::rsqueeze to substitute characters at the end of a string by "...". Default maxlen is 40 (see the second screenshot), maybe we should increase it?
> 
> 
> Diffs
> -----
> 
>   shell/session.cpp 55821a9 
> 
> Diff: http://git.reviewboard.kde.org/r/111132/diff/
> 
> 
> Testing
> -------
> 
> See the screenshot.
> 
> 
> File Attachments
> ----------------
> 
> before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/19/before.png
> after
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/19/after.png
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130619/9870e35e/attachment.html>