Review Request 111133: Proper support of FORCE statement in cmake set

[Sergey Vidyuk]

В письме от 19 июня 2013 17:44:04 пользователь Aleix Pol Gonzalez написал:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111133/#review34698
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Ship It!
> 
> - Aleix Pol Gonzalez
> 
> On June 19, 2013, 5:42 p.m., Sergey Vidyuk wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/111133/
> > -----------------------------------------------------------
> > 
> > (Updated June 19, 2013, 5:42 p.m.)
> > 
> > 
> > Review request for KDevelop.
> > 
> > 
> > Description
> > -------
> > 
> > _qt4_find_qmake is recursive function which uses two conditions to stop
> > recursion. One of them relies on changing of QT_QMAKE_EXECUTABLE cached
> > variable using forced set. This commit handles forced set syntax
> > correctly. Partially related to
> > https://bugs.kde.org/show_bug.cgi?id=320875
> > 
> > 
> > Diffs
> > -----
> > 
> >   projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 5299b7c
> > 
> > Diff: http://git.reviewboard.kde.org/r/111133/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > manually tested with extra logs
> > 
> > 
> > Thanks,
> > 
> > Sergey Vidyuk

Formatted patch is attached

Sergey Vidyuk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Update-global-vars-when-visiting-set-.CACHE.FORCE-AS.patch
Type: text/x-patch
Size: 1074 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130620/a3a64cf9/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130620/a3a64cf9/attachment-0001.sig>