Review Request 111052: Prevent CustomBuildSystem from crashes

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jun 18 10:47:58 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111052/
-----------------------------------------------------------

(Updated June 18, 2013, 10:47 a.m.)


Status
------

This change has been discarded.


Review request for KDevelop and Andreas Pakulat.


Description
-------

Well, I decided to give the CustomBuildSystem a try to develop a non-cmake project. It was crashing all the time because the configuration wasn't initialized and I got crashes because of usage of invalid KConfigGroup. I guess other people are not hitting this because their kdelibs is not compiled in debug and they don't get crashes on Q_ASSERT.

This patch only has changes to letting me work with it but I didn't put much attention on it. Still I'd like if Andreas could look into this and see what's the best solution-


Diffs
-----

  projectmanagers/custom-buildsystem/custombuildjob.cpp 84ac8c2 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp 3d47dba 

Diff: http://git.reviewboard.kde.org/r/111052/diff/


Testing
-------

Managed to use it a bit, not much.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130618/2c83e59b/attachment-0001.html>


More information about the KDevelop-devel mailing list