Review Request 110926: Update the VCSEventModel when the VCS Job is Finished

[Aleix Pol Gonzalez]

> On June 10, 2013, 1:27 a.m., Aleix Pol Gonzalez wrote:
> > Can you push it to 1.5 too?
> > 
> > PS: You could test with git too... kdevelop itself is git afterall, no? ;)
> 
> David Narváez wrote:
>     Should I fix in 1.5 and then merge to master? Or should I cherry-pick from master?
>     
>     It is harder to find the 100th commit in a git project using the History widget.
> 
> Aleix Pol Gonzalez wrote:
>     Fix in 1.5 then merge.
> 
> David Narváez wrote:
>     This fix does not apply to 1.5, in fact the underlying bug does not exist in 1.5.

Uh ok, I didn't think the branching of 1.5 was so old. Ok, then please submit to master and excuse the noise.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110926/#review34004
-----------------------------------------------------------


On June 10, 2013, 1:17 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110926/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 1:17 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This fixes a situation where SVN log was not being loaded correctly and was showing just the latest event.
> 
> 
> Diffs
> -----
> 
>   vcs/models/vcseventmodel.h b4e4f15 
>   vcs/models/vcseventmodel.cpp 8641f2f 
> 
> Diff: http://git.reviewboard.kde.org/r/110926/diff/
> 
> 
> Testing
> -------
> 
> 1. Loaded 2 SVN projects
> 2. Checked the 100th and 101st log entries in each to verify nothing is skipped
> 
> Didn't test this with git projects but I believe nothing should be affected there.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130610/0f0e7aa8/attachment.html>