Review Request 110858: Cleanup KDE development scripts
Vadim Zhukov
persgray at gmail.com
Thu Jun 6 22:53:36 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110858/
-----------------------------------------------------------
Review request for KDevelop.
Description
-------
Many KDE development scripts were written in a hurry and are:
* unportable, e.g.: using bash instead of sh
* unreliable, e.g.: using of $* instead of $@ in shell scripts
* unsecure, e.g.: using open($file) idiom in Perl scripts
I tweaked most obvious stuff that I found. This patch allows to better integrate KDE development process into OpenBSD ecosystem, and, probably, in ecosystem of other OSes. Not saying about getting more reliable results for non-usual cases, such as filenames with non-ASCII-alphanum-characters in them.
Given that KDE5 is coming, I think it's a good time to improve some core stuff. :)
Diffs
-----
adddebug 782db52
build-progress.sh 64247fc
colorsvn 84dec6b
cvsblame bd3635e
cvslastlog d1b4581
kf5/functionUtilkde.pm 79b6547
nonsvnlist f94c3e8
package_crystalsvg 1502da2
qt4/adapt-kconfiggroupsaver.pl ccd0e4e
qt4/adapt-to-kde4-api.pl 8364ef4
qt4/adapt-to-new-kconfig2.pl b0e660f
qt4/adapt-to-new-kdebug-api.pl cf96261
qt4/adapt-to-qt4-api.pl c225c62
qt4/convert-bad-qdatastream.pl 779b0a0
qt4/convert-display.pl 2c971b6
qt4/convert-find-to-indexof.pl f732684
qt4/convert-kgenericfactory.pl f8355bd
qt4/convert-killtimers.pl 60be59e
qt4/convert-kinstance.pl ca3d590
qt4/convert-kkeydialog.pl f5581b4
qt4/convert-kmimetype-pixmap.pl 003c9fb
qt4/convert-kstringhandler.pl 0b42bc5
qt4/convert-newq4headers.pl 57c5148
qt4/convert-q3cstring.pl a6a1919
qt4/convert-qboxlayout.pl 564e197
qt4/convert-qgridlayout.pl 367dca0
qt4/convert-qiodevice_at.pl ff1ae8f
qt4/convert-qlabel.pl 4f0f3c4
qt4/convert-qstringlatin1.pl 76f3de6
qt4/convert-qvhbox.pl 7ab1afa
qt4/convert-signal.pl be50e9d
qt4/fix-link.pl 34ae20b
qt4/functionUtilkde.pm 79b6547
qt4/icons-kde3tokde4-renamer/icons-kde3to4-renamer.sh 97cecd1
qt4/remove-qt3-support.pl 0e34b8a
qt4/replaceRenamedDeprecated.sh fa7cd06
qt4/search-qstringlist.sh 2601441
qt4/search-qwhatsthis.sh a34857c
qt4/search-registeredApplications.sh 31911ba
svn-clean 3c698bd
svn2log.sh ef78f56
svnaddcurrentdir 53eb384
svnforwardport f8dd9d6
svnversions fbdca03
unsercmake 24170ab
wcgrep 477bab5
Diff: http://git.reviewboard.kde.org/r/110858/diff/
Testing
-------
Light tested on OpenBSD-CURRENT, from KDE 4.10.1 till 4.10.4. As I'm not a KDE developer, this definitely needs more precise look.
Thanks,
Vadim Zhukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130606/7c547cbc/attachment.html>
More information about the KDevelop-devel
mailing list