Review Request 110374: Add support for php 5.4's short array syntax.

Heinz Wiesinger hmwiesinger at liwjatan.at
Sat Jun 1 20:01:55 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110374/
-----------------------------------------------------------

(Updated June 1, 2013, 8:01 p.m.)


Review request for KDevelop.


Changes
-------

Added unit test


Description
-------

A first step towards support for the new syntax features introduced in PHP 5.4.
This implements parsing support for the short (json-style) array syntax where one can rewrite

$var = array( "key" => "value" );

as

$var = [ "key" => "value" ];


This addresses bug 305779.
    http://bugs.kde.org/show_bug.cgi?id=305779


Diffs (updated)
-----

  duchain/tests/expressionparser.h f6eb53032010e9f37106cd5cdc851fa24d9e7b99 
  duchain/tests/expressionparser.cpp 4a906406cf2aec629169366b58aa8c52cea920f1 
  parser/php.g ad60514c22795cbc1aa16a7fc8de2ea696859487 

Diff: http://git.reviewboard.kde.org/r/110374/diff/


Testing
-------

I tested this locally with kdevplatform 1.5.0 and kdevelop 4.5.0.


Thanks,

Heinz Wiesinger

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130601/d4367087/attachment.html>


More information about the KDevelop-devel mailing list