Review Request 111781: GrepView: Use combo box with a list of recent locations instead of edit line.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111781/#review36820
-----------------------------------------------------------

Ship it!


yay, nearly there! if you fix the comment, feel free to push the changes upstream.

thank you!


plugins/grepview/grepdialog.h
<http://git.reviewboard.kde.org/r/111781/#comment27167>

    please add a short comment, saying it can be semicolon separated list of directories. also the special strings should be mentioned.


- Milian Wolff


On July 30, 2013, 11:29 a.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111781/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 11:29 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch improves usability of "Find in files" dialog. Now it possible to use recently used search locations. Additional, maybe even useful, information can be found in "Please use ReviewBoard" thread from 27.07.13
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepdialog.h d197ea2 
>   plugins/grepview/grepdialog.cpp cdbc1cf 
>   plugins/grepview/grepviewplugin.cpp dffc065 
>   plugins/grepview/grepwidget.ui 5ad3615 
> 
> Diff: http://git.reviewboard.kde.org/r/111781/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130730/c12a1022/attachment.html>