Review Request 111796: Avoid endless recursions in TemplateDeclaration::setSpecializedFrom

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111796/#review36802
-----------------------------------------------------------


Neat, if the unit tests still all pass, then please go for it. This looks simple enough and I cannot see a simple way this could break. But then again, the surrounding code is not simple and is a perfect butterfly effect testground... So please, make sure the tests pass.

- Milian Wolff


On July 30, 2013, 12:39 p.m., Andreas Pakulat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111796/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 12:39 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Avoid endless recursions in TemplateDeclaration::setSpecializedFrom
> 
> Having two template specializations with the same signature causes an
> endless recursion here. I don't see a reason why a TemplateDeclaration
> should update its 'specializedFrom' stuff if that already is up-to-date.
> So in the case the other->specializedFrom.data() is already what this
> declaration has, there's simply nothing to do.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/templatedeclaration.cpp b35ba13a0eacb5157a921cf96fdc22c091f625e1 
> 
> Diff: http://git.reviewboard.kde.org/r/111796/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Pakulat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130730/b4f40ac9/attachment.html>