Review Request 111781: GrepView: Use combo box with a list of recent locations instead of edit line.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111781/#review36771
-----------------------------------------------------------


reviewing changes to .ui files is always a bit of a hassle, could you please attach a before/after screenshot (or did nothing visually change and designer just changed stuff too much?)


plugins/grepview/grepdialog.cpp
<http://git.reviewboard.kde.org/r/111781/#comment27148>

    this should be done in setDirectory



plugins/grepview/grepdialog.cpp
<http://git.reviewboard.kde.org/r/111781/#comment27149>

    this should keep a LRU order, i.e. always remove the item and then add it.
    
    do the same for the searchPaths GUI item.
    
    also ensure not too many search paths are added, limit iat to 10 or 20 or 25 or something like that.


- Milian Wolff


On July 29, 2013, 5:18 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111781/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 5:18 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> See mail list for details.
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepdialog.h d197ea2 
>   plugins/grepview/grepdialog.cpp cdbc1cf 
>   plugins/grepview/grepwidget.ui 5ad3615 
> 
> Diff: http://git.reviewboard.kde.org/r/111781/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130729/0f4a7d69/attachment.html>