Review Request 110298: added kdevplatform part of kdevelop zsh integration

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110298/#review36596
-----------------------------------------------------------


in general looks good, but I don't know about the .bashrc thingy


util/CMakeLists.txt
<http://git.reviewboard.kde.org/r/110298/#comment27000>

    as said in the other review, push the zsh specific stuff into its own subfolder please



util/kdevplatform_shell_environment.sh
<http://git.reviewboard.kde.org/r/110298/#comment27001>

    this does not load the ~/.bashrc anymore, as the old code used to do - why? looking at the contents, this file loads my .bashrc - is this "documented" / "indented" behavior and we can rely on that to keep backwards compatibility?
    
    generally though, shouldn't one _first_ load the global stuff and then "overwrite" that by the local configuration?


- Milian Wolff


On July 22, 2013, 10:16 p.m., Phil Schaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110298/
> -----------------------------------------------------------
> 
> (Updated July 22, 2013, 10:16 p.m.)
> 
> 
> Review request for KDevelop and David Nolden.
> 
> 
> Description
> -------
> 
> added kdevplatform part of kdevelop zsh integration
> 
> sister review of https://git.reviewboard.kde.org/r/110299/
> 
> 
> Diffs
> -----
> 
>   util/.zshrc PRE-CREATION 
>   util/CMakeLists.txt 29de12617b4e9d7697abc73465ed435b9039c531 
>   util/kdevplatform_shell_environment.sh d2ece7f9286f8cb8ae35c672a29d5248e2c1a199 
> 
> Diff: http://git.reviewboard.kde.org/r/110298/diff/
> 
> 
> Testing
> -------
> 
> I don’t know if $OLD_ZDOTDIR gets carried over to “kdevplatform_shell_environment.sh” through “.zshrc”!
> 
> can someone help here?
> 
> 
> Thanks,
> 
> Phil Schaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130727/0dba0e3c/attachment.html>