Review Request 111637: Increased the number of registrable types to 256.

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111637/#review36281
-----------------------------------------------------------



language/duchain/types/typeregister.h
<http://git.reviewboard.kde.org/r/111637/#comment26827>

    What bug does this assert try to prevent? I don't see why the code would limit the number of AbstractType subclasses by an arbitrary number?
    
    If there is a reason then a comment about it would be good to have here IMO.


- Andreas Pakulat


On July 22, 2013, 6:31 a.m., Miquel Sabaté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111637/
> -----------------------------------------------------------
> 
> (Updated July 22, 2013, 6:31 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> As discussed in the Akademy, it's needed to increase the number of registrable types. Thus, this patch. I've also removed some old code that was commented out and imho was no longer needed.
> 
> 
> Diffs
> -----
> 
>   language/duchain/types/typeregister.h 4843eec 
> 
> Diff: http://git.reviewboard.kde.org/r/111637/diff/
> 
> 
> Testing
> -------
> 
> As an example, I've set the Ruby's ClassType Identity to 250 and everything performed as usual.
> 
> 
> Thanks,
> 
> Miquel Sabaté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130722/62283db0/attachment.html>