Review Request 111559: Add support for PHP 5.5's string literal dereferencing.

Milian Wolff mail at milianw.de
Thu Jul 18 09:32:05 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111559/#review36101
-----------------------------------------------------------

Ship it!


Sigh, I should remember that reasoning with the PHP language never works :D

Go ahead then!

- Milian Wolff


On July 18, 2013, 9:14 a.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111559/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 9:14 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Add support for PHP 5.5's string literal dereferencing.
> 
> I opted for creating a new stringIndexIdentifier token as [] is not supported for strings.
> 
> 
> Diffs
> -----
> 
>   duchain/tests/expressionparser.h a749e973d11505d94abf1ea43d45513ca22d5244 
>   duchain/tests/expressionparser.cpp 72970fce85153fdb1baf97163c306a0e6c312d6c 
>   parser/php.g 55b7b64de919137b03331569381dee45cdb21fb2 
> 
> Diff: http://git.reviewboard.kde.org/r/111559/diff/
> 
> 
> Testing
> -------
> 
> Unit tests, checked example code
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130718/5b9ee5ba/attachment.html>


More information about the KDevelop-devel mailing list