Review Request 111531: Fix CodeAnalysisTest

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111531/#review36046
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On July 16, 2013, 12:18 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111531/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 12:18 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> The unit test is broken, I think b/c the logic is wrong in the code, i.e. it checked for const and applied read/write to it, whereas non-const got only read access.
> 
> Also, how should the stuff with the "do I have an argument or not?" work? the test used to have an operator++(int) or so which simply did nothing?
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/tests/codeanalysistest.cpp e77f961 
>   languages/cpp/cppduchain/usedecoratorvisitor.cpp 57dfd88 
> 
> Diff: http://git.reviewboard.kde.org/r/111531/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass, but are not checking the operator++(int) case anymore.
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130716/e96cf7d5/attachment.html>