Review Request 111477: Added the Github plugin to the kdevelop repository.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111477/#review35851
-----------------------------------------------------------


Like I said in the mailing list, I'd leave kdeprovider in kdeintegration...

Also it's better to create the patches with --find-copies-harder, so that moves reflect in the patch.

- Aleix Pol Gonzalez


On July 10, 2013, 7:23 p.m., Miquel Sabaté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111477/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 7:23 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> In this review I'm adding the Github plugin that I've been working on in a scratch repo: http://quickgit.kde.org/?p=scratch%2Fmssola%2Fghprovider.git to the KDevelop repository. I've created the "providers" directory again, and I've put in there the KDE Provider plugin and this new Github plugin.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8d2f8bb 
>   kdeintegration/CMakeLists.txt 9787c8c 
>   kdeintegration/kdeprovider/CMakeLists.txt 2aec9b0 
>   kdeintegration/kdeprovider/Messages.sh d23e4f3 
>   kdeintegration/kdeprovider/kdeconfig.kcfg c81fc41 
>   kdeintegration/kdeprovider/kdeconfig.kcfgc a922c7c 
>   kdeintegration/kdeprovider/kdeconfig.ui 1222385 
>   kdeintegration/kdeprovider/kdeprojectsmodel.h 3218a56 
>   kdeintegration/kdeprovider/kdeprojectsmodel.cpp 0b70fd8 
>   kdeintegration/kdeprovider/kdeprojectsreader.h 18fe881 
>   kdeintegration/kdeprovider/kdeprojectsreader.cpp 7e99155 
>   kdeintegration/kdeprovider/kdeproviderplugin.h efca862 
>   kdeintegration/kdeprovider/kdeproviderplugin.cpp 72bc9d2 
>   kdeintegration/kdeprovider/kdeproviderwidget.h 4904c32 
>   kdeintegration/kdeprovider/kdeproviderwidget.cpp 8b92c67 
>   kdeintegration/kdeprovider/kdevkdeprovider.desktop.cmake c6242ff 
>   kdeintegration/kdeprovider/tests/CMakeLists.txt 7858f0d 
>   kdeintegration/kdeprovider/tests/kdeprojectsreadertest.h 7092d51 
>   kdeintegration/kdeprovider/tests/kdeprojectsreadertest.cpp dd2fb51 
>   providers/CMakeLists.txt PRE-CREATION 
>   providers/ghprovider/CMakeLists.txt PRE-CREATION 
>   providers/ghprovider/README.md PRE-CREATION 
>   providers/ghprovider/cmake/CMakeLists.txt PRE-CREATION 
>   providers/ghprovider/cmake/FindQJson.cmake PRE-CREATION 
>   providers/ghprovider/ghaccount.h PRE-CREATION 
>   providers/ghprovider/ghaccount.cpp PRE-CREATION 
>   providers/ghprovider/ghdialog.h PRE-CREATION 
>   providers/ghprovider/ghdialog.cpp PRE-CREATION 
>   providers/ghprovider/ghlineedit.h PRE-CREATION 
>   providers/ghprovider/ghlineedit.cpp PRE-CREATION 
>   providers/ghprovider/ghprovidermodel.h PRE-CREATION 
>   providers/ghprovider/ghprovidermodel.cpp PRE-CREATION 
>   providers/ghprovider/ghproviderplugin.h PRE-CREATION 
>   providers/ghprovider/ghproviderplugin.cpp PRE-CREATION 
>   providers/ghprovider/ghproviderwidget.h PRE-CREATION 
>   providers/ghprovider/ghproviderwidget.cpp PRE-CREATION 
>   providers/ghprovider/ghresource.h PRE-CREATION 
>   providers/ghprovider/ghresource.cpp PRE-CREATION 
>   providers/ghprovider/icons/CMakeLists.txt PRE-CREATION 
>   providers/ghprovider/icons/hi16-app-github-forked.png PRE-CREATION 
>   providers/ghprovider/icons/hi16-app-github-private.png PRE-CREATION 
>   providers/ghprovider/icons/hi16-app-github-repo.png PRE-CREATION 
>   providers/ghprovider/icons/hi16-app-kdevgh.png PRE-CREATION 
>   providers/ghprovider/icons/hi32-app-kdevgh.png PRE-CREATION 
>   providers/ghprovider/kdevghprovider.desktop PRE-CREATION 
>   providers/kdeprovider/CMakeLists.txt PRE-CREATION 
>   providers/kdeprovider/Messages.sh PRE-CREATION 
>   providers/kdeprovider/kdeconfig.kcfg PRE-CREATION 
>   providers/kdeprovider/kdeconfig.kcfgc PRE-CREATION 
>   providers/kdeprovider/kdeconfig.ui PRE-CREATION 
>   providers/kdeprovider/kdeprojectsmodel.h PRE-CREATION 
>   providers/kdeprovider/kdeprojectsmodel.cpp PRE-CREATION 
>   providers/kdeprovider/kdeprojectsreader.h PRE-CREATION 
>   providers/kdeprovider/kdeprojectsreader.cpp PRE-CREATION 
>   providers/kdeprovider/kdeproviderplugin.h PRE-CREATION 
>   providers/kdeprovider/kdeproviderplugin.cpp PRE-CREATION 
>   providers/kdeprovider/kdeproviderwidget.h PRE-CREATION 
>   providers/kdeprovider/kdeproviderwidget.cpp PRE-CREATION 
>   providers/kdeprovider/kdevkdeprovider.desktop.cmake PRE-CREATION 
>   providers/kdeprovider/tests/CMakeLists.txt PRE-CREATION 
>   providers/kdeprovider/tests/kdeprojectsreadertest.h PRE-CREATION 
>   providers/kdeprovider/tests/kdeprojectsreadertest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111477/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Miquel Sabaté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130710/0adfcc61/attachment.html>