Review Request 111151: Fix incorrect debug session ending.

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jul 9 16:02:09 UTC 2013



> On July 9, 2013, 3:27 p.m., Vlas Puhov wrote:
> > I've come across very interesting function in DebugSession, so now all checks go there.

You're not really supposed to give Ship it to yourself...

Anyway don't revert it, it looks like a useful patch.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111151/#review35791
-----------------------------------------------------------


On July 9, 2013, 3:28 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111151/
> -----------------------------------------------------------
> 
> (Updated July 9, 2013, 3:28 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> If commands like c, n, ni,si... were send directly to gdb, it may exit with message like "~\"[Inferior * (process *) exited *", but miparser treats it like usual message. 
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/mi/miparser.h 7096af0 
>   debuggers/gdb/mi/miparser.cpp a17e644 
>   debuggers/gdb/unittests/gdbtest.h bd5d90d 
>   debuggers/gdb/unittests/gdbtest.cpp efcab9d 
> 
> Diff: http://git.reviewboard.kde.org/r/111151/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130709/0f3a562e/attachment.html>


More information about the KDevelop-devel mailing list