Review Request 111400: Fixed displaying text in quickopen widget when window and view have colors of the opposite brightness

Milian Wolff mail at milianw.de
Sat Jul 6 13:35:03 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111400/#review35658
-----------------------------------------------------------

Ship it!


Imo the patch looks fine, go for it!

- Milian Wolff


On July 5, 2013, 3:18 p.m., Bartosz Matuszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111400/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 3:18 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fixed displaying text in quickopen widget when window and view have background colors of the opposite brightness e.g. when window was bright and view was dark text in view was also dark and almost impossible to read.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/expandingtree/expandingdelegate.cpp de25eba 
> 
> Diff: http://git.reviewboard.kde.org/r/111400/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> befor&after screenshot
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/05/before_after.png
> 
> 
> Thanks,
> 
> Bartosz Matuszewski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130706/0e56df9b/attachment.html>


More information about the KDevelop-devel mailing list