Review Request 111400: Fixed displaying text in quickopen widget when window and view have colors of the opposite brightness

[Sven Brauch]

> On July 5, 2013, 9:09 a.m., Aleix Pol Gonzalez wrote:
> > The correct way for doing this would be using QStyle::drawPrimitive:
> > void MyWidget::paintEvent(QPaintEvent * /* event */)
> > {
> >     QPainter painter(this);
> > 
> >     QStyleOptionFocusRect option;
> >     option.initFrom(this);
> >     option.backgroundColor = palette().color(QPalette::Background);
> > 
> >     style()->drawPrimitive(QStyle::PE_FrameFocusRect, &option, &painter, this);
> > }
> > 
> > The color seems to be correct at the moment.
> > 
> > Also for graphical changes it works much smoother if you can provide before+after screenshots

Could you explain why this would be the correct way to do it?


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111400/#review35619
-----------------------------------------------------------


On July 5, 2013, 1:54 a.m., Bartosz Matuszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111400/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 1:54 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fixed displaying text in quickopen widget when window and view have background colors of the opposite brightness e.g. when window was bright and view was dark text in view was also dark and almost impossible to read.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/expandingtree/expandingdelegate.cpp de25eba 
> 
> Diff: http://git.reviewboard.kde.org/r/111400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bartosz Matuszewski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130705/606cc99e/attachment.html>