Review Request 111400: Fixed displaying text in quickopen widget when window and view have colors of the opposite brightness
Sven Brauch
svenbrauch at gmx.de
Fri Jul 5 08:43:13 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111400/#review35617
-----------------------------------------------------------
Ship it!
The patch looks correct, and I also remember having issues with this with some themes.
For such a patch, adding before-after-screenshots to the review request is always nice to advertise its usefulness :)
- Sven Brauch
On July 5, 2013, 1:54 a.m., Bartosz Matuszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111400/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 1:54 a.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> Fixed displaying text in quickopen widget when window and view have background colors of the opposite brightness e.g. when window was bright and view was dark text in view was also dark and almost impossible to read.
>
>
> Diffs
> -----
>
> plugins/quickopen/expandingtree/expandingdelegate.cpp de25eba
>
> Diff: http://git.reviewboard.kde.org/r/111400/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bartosz Matuszewski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130705/b137b8c1/attachment.html>
More information about the KDevelop-devel
mailing list